Skip to content

Renamed linsolve to lup_solve, added docs, and refactored#29

Merged
pasabanov merged 1 commit intomainfrom
linalg
Feb 9, 2025
Merged

Renamed linsolve to lup_solve, added docs, and refactored#29
pasabanov merged 1 commit intomainfrom
linalg

Conversation

@pasabanov
Copy link
Copy Markdown
Member

Types of changes

  • Documentation
  • Refactoring, reformatting, cleanup

Related: #7

Description

  1. Renamed linsolve to lup_solve to reflect that the function uses LUP decomposition.
  2. Added corresponding documentation.
  3. Renamed N variable to n for consistency with other functions.
  4. Removed vector P and implemented direct swapping of elements in B instead for performance.
  5. Changed B type from l-value reference to r-value reference.
  6. Removed excessive whitespace.
  7. Added two assert statements to improve code safety.

@pasabanov pasabanov added docs Improvements or additions to documentation refactor Improving code structure without adding new functionality labels Feb 9, 2025
@pasabanov pasabanov added this to the First Release Version milestone Feb 9, 2025
@pasabanov pasabanov self-assigned this Feb 9, 2025
@pasabanov pasabanov merged commit 61a30e3 into main Feb 9, 2025
5 checks passed
@pasabanov pasabanov deleted the linalg branch February 9, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation refactor Improving code structure without adding new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant